Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2134] Fix broken code highlighting in Code Panel #2135

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[#2134] Fix broken code highlighting in Code Panel #2135

merged 1 commit into from
Feb 21, 2024

Conversation

ckcherry23
Copy link
Member

Fixes #2134

Proposed commit message

The code highlighting is not working as the colors are not being
recognized by the newly extracted c-segment.vue file. This is because
the defined colors were not imported into the file.  

Let us add the color styles import to restore code highlighting
functionality.

Other information

NIL

@ckcherry23 ckcherry23 requested review from a team February 21, 2024 09:26
sopa301
sopa301 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@sopa301 sopa301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

MarcusTXK
MarcusTXK approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job with the detection and quick fix of the issue

@MarcusTXK MarcusTXK requested a review from a team February 21, 2024 09:56
vvidday
vvidday approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@vvidday vvidday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Let's skip the 2 day waiting period as this is urgent

@vvidday vvidday merged commit 6b31128 into reposense:master Feb 21, 2024
10 checks passed
@github-actions GitHub Actions
Copy link
Contributor

The following links are for previewing this pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopa301 sopa301 sopa301 approved these changes

@MarcusTXK MarcusTXK MarcusTXK approved these changes

@vvidday vvidday vvidday approved these changes

Assignees
No one assigned
Labels
p.Urgent s.FinalReview s.ToReview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken code highlighting in Code Panel
4 participants
@ckcherry23 @vvidday @MarcusTXK @sopa301